filter: Deprecate --output and -o
#1622
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to search for usage, since `args.output` also matches other output options.
Planning for upcoming deprecation.
- Put options in a new argument group for deprecated options - Add entry to DEPRECATED.md - Add test to ensure deprecated options still work
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1622 +/- ##
==========================================
+ Coverage 71.03% 71.06% +0.03%
==========================================
Files 79 79
Lines 8258 8268 +10
Branches 2005 2007 +2
==========================================
+ Hits 5866 5876 +10
Misses 2101 2101
Partials 291 291 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
--outputand-oare aliases to--output-sequences. They will be removed to avoid confusion with other output options.Related issue(s)
Closes #1607
Checklist